Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add missing parameters to offsets classes: BYearBegin, YearEnd, YearBegin #53280

Conversation

natmokval
Copy link
Contributor

xref #52431
Updated documentation for offsets classes. Added missing parameters, See Also section, and examples to BYearBegin, YearEnd, and YearBegin. Corrected the default value for month in the class BYearEnd.

@natmokval natmokval marked this pull request as ready for review May 17, 2023 23:02
@rhshadrach rhshadrach added Docs Frequency DateOffsets labels May 18, 2023
@natmokval
Copy link
Contributor Author

@MarcoGorelli, could you please take a look at this pr?

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone May 18, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli merged commit b2bb68a into pandas-dev:main May 18, 2023
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
…YearBegin (pandas-dev#53280)

* DOC: add missing parameters to offsets classes: BYearBegin, YearEnd, YearBegin

* update "get to the end of the year" suggestion to use rollforward instead of rollback

---------

Co-authored-by: Marco Edward Gorelli <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…YearBegin (pandas-dev#53280)

* DOC: add missing parameters to offsets classes: BYearBegin, YearEnd, YearBegin

* update "get to the end of the year" suggestion to use rollforward instead of rollback

---------

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants