Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGR: MultiIndex.join not resorting levels of new index #53102

Merged
merged 2 commits into from
May 5, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented May 5, 2023

Not resorting causes all kinds of problems when indexing

@phofl phofl added this to the 2.0.2 milestone May 5, 2023
@phofl phofl added Regression Functionality that used to work in a prior pandas version MultiIndex labels May 5, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Just a merge conflict

@phofl
Copy link
Member Author

phofl commented May 5, 2023

Cleaned up, we should aim at fixing this properly for 2.1, because you can still end up like this if you instantiate the MultiIndex directly

@phofl phofl merged commit ddff84a into pandas-dev:main May 5, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented May 5, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ddff84a5ddbf55b5f407976be359720804cd6981
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #53102: REGR: MultiIndex.join not resorting levels of new index'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-53102-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53102 on branch 2.0.x (REGR: MultiIndex.join not resorting levels of new index)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl
Copy link
Member Author

phofl commented May 5, 2023

@meeseeksdev backport 2.0.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request May 5, 2023
phofl added a commit that referenced this pull request May 6, 2023
…ng levels of new index) (#53113)

Backport PR #53102: REGR: MultiIndex.join not resorting levels of new index

Co-authored-by: Patrick Hoefler <[email protected]>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Equal input DataFrames but different results
2 participants