Fix bug #37782 #53099
Merged
Fix bug #37782 #53099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 5, 2023
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -372,10 +372,10 @@ I/O | |||
| ^^^ | |||
| - :meth:`DataFrame.to_orc` now raising ``ValueError`` when non-default :class:`Index` is given (:issue:`51828`) | |||
| - :meth:`DataFrame.to_sql` now raising ``ValueError`` when the name param is left empty while using SQLAlchemy to connect (:issue:`52675`) | |||
| - Bug in :func:`json_normalize`, json_normalize cannot parse metadata fields list type (:issue:`#37782`) | |||
There was a problem hiding this comment.
Suggested change
| - Bug in :func:`json_normalize`, json_normalize cannot parse metadata fields list type (:issue:`#37782`) | |
| - Bug in :func:`json_normalize`, json_normalize cannot parse metadata fields list type (:issue:`37782`) |
There was a problem hiding this comment.
@mroeschke I'm seeing the message: This branch has conflicts that must be resolved
Only those with write access to this repository can merge pull requests.
Conflicting files
doc/source/whatsnew/v2.1.0.rst
Can you please take a look and guide me on this?
There was a problem hiding this comment.
Please follow these constructions to update your branch and fix the conflict: https://pandas.pydata.org/docs/development/contributing.html#updating-your-pull-request
mroeschke
reviewed
May 5, 2023
| @@ -137,6 +137,11 @@ def max_level_test_input_data(): | |||
| ] | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def parse_metadata_fields_list_type(): | |||
There was a problem hiding this comment.
Can you just hardcode this in the function?
There was a problem hiding this comment.
@mroeschke like that?
def test_fields_list_type_normalize(self):
parse_metadata_fields_list_type=[{"values": [1, 2, 3], "metadata": {"listdata": [1, 2]}}]
result = json_normalize(
parse_metadata_fields_list_type,
record_path=["values"],
meta=[["metadata", "listdata"]],
)
expected = DataFrame(
{0: [1, 2, 3], "metadata.listdata": [[1, 2], [1, 2], [1, 2]]}
)
tm.assert_frame_equal(result, expected)
Should I push it? I did this as function just by looking other examples in the file.
Let me know.
There was a problem hiding this comment.
@mroeschke I just did it. But things looks different. I'm not sure if it was pushed properly. Can you check please?
(My first PR for a big project)
mroeschke
reviewed
May 5, 2023
mroeschke
reviewed
May 8, 2023
mroeschke
approved these changes
May 8, 2023
|
Thanks @felipemaion |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Fix BUG: pandas-dev#37782 * Fix BUG: pandas-dev#37782 * Fix BUG: 37782 - Hardcoded test data * Fix BUG: 37782 - Hardcoded test data * Update pandas/io/json/_normalize.py Co-authored-by: Matthew Roeschke <[email protected]> * Fix BUG: 37782 - typo * Fix BUG: 37782 - typo * Update doc/source/whatsnew/v2.1.0.rst --------- Co-authored-by: Matthew Roeschke <[email protected]>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Fix BUG: pandas-dev#37782 * Fix BUG: pandas-dev#37782 * Fix BUG: 37782 - Hardcoded test data * Fix BUG: 37782 - Hardcoded test data * Update pandas/io/json/_normalize.py Co-authored-by: Matthew Roeschke <[email protected]> * Fix BUG: 37782 - typo * Fix BUG: 37782 - typo * Update doc/source/whatsnew/v2.1.0.rst --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile.