STY: Enable pygrep ruff checks #53062
Conversation
|
|
||
| # TODO(wesm), incomplete test? | ||
| indexed_frame = DataFrame(data, index=index) # noqa | ||
| unindexed_frame = DataFrame(data) # noqa |
There was a problem hiding this comment.
did you make a decision to remove this or was it automated? id be OK with the former
There was a problem hiding this comment.
I made the decision to remove this since it didn't seem clear that this would be fixed
pandas/_libs/lib.pyi
Outdated
| @@ -30,7 +30,7 @@ from enum import Enum | |||
| class _NoDefault(Enum): | |||
| no_default = ... | |||
|
|
|||
| no_default: Final = _NoDefault.no_default # noqa | |||
| no_default: Final = ... | |||
There was a problem hiding this comment.
I think this will break some type annotations
There was a problem hiding this comment.
typeshed also does this python/typeshed#7127 not sure whether this is a "bug" in ruff
There was a problem hiding this comment.
Ah okay thanks I'll add back the noqa
| def test_index_from_series_copy(using_copy_on_write): | ||
| def test_index_from_series_copy(): |
There was a problem hiding this comment.
why remove using_copy_on_write?
There was a problem hiding this comment.
Oops, I removed this by accident. I reverted this
| @@ -265,7 +265,7 @@ def test_from_records_to_records(self): | |||
| arr[:] = [(1, 2.0, "Hello"), (2, 3.0, "World")] | |||
|
|
|||
| # TODO(wesm): unused | |||
| result = empty_float.fillna(value=0) # noqa | ||
| float_frame.reindex(columns=[]) |
There was a problem hiding this comment.
might want to keep the fillna?
There was a problem hiding this comment.
Ah good catch. Added back
* STY: Enable pygrep ruff checks * Address comments * Uncomment code * Address comments
* STY: Enable pygrep ruff checks * Address comments * Uncomment code * Address comments
* STY: Enable pygrep ruff checks * Address comments * Uncomment code * Address comments
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.