Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Revert DataFrameGroupBy.apply operating on the group keys #52921

Merged
merged 3 commits into from
Apr 28, 2023
Merged

DEPR: Revert DataFrameGroupBy.apply operating on the group keys #52921

merged 3 commits into from
Apr 28, 2023

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Apr 25, 2023 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Reverts #52477

@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas Apply Apply, Aggregate, Transform, Map labels Apr 25, 2023
@rhshadrach rhshadrach added this to the 2.1 milestone Apr 25, 2023
@rhshadrach rhshadrach requested a review from phofl April 25, 2023 21:30
@phofl
Copy link
Member

phofl commented Apr 27, 2023

Thx, could you rebase? This should get the numpy dev build green

@rhshadrach
Merge branch 'main' of https://github.com/pandas-dev/pandas into reve…
f57b37a 
…rt_gb_apply_depr

# Conflicts:
#	pandas/tests/groupby/test_groupby.py
mroeschke
mroeschke approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready @phofl

@phofl phofl merged commit 9f5b44c into pandas-dev:main Apr 28, 2023
@phofl
Copy link
Member

phofl commented Apr 28, 2023

thx @rhshadrach

@rhshadrach rhshadrach deleted the revert_gb_apply_depr branch April 28, 2023 22:03
NumanIjaz pushed a commit to NumanIjaz/pandas that referenced this pull request May 1, 2023
@rhshadrach @NumanIjaz
DEPR: Revert DataFrameGroupBy.apply operating on the group keys (pand…
3d91468 
…as-dev#52921)

Revert "DEPR: DataFrameGroupBy.apply operating on the group keys (pandas-dev#52477)"

This reverts commit 9b20759.
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
@rhshadrach @topper-123
DEPR: Revert DataFrameGroupBy.apply operating on the group keys (pand…
f9b0f89 
…as-dev#52921)

Revert "DEPR: DataFrameGroupBy.apply operating on the group keys (pandas-dev#52477)"

This reverts commit 9b20759.
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@rhshadrach
DEPR: Revert DataFrameGroupBy.apply operating on the group keys (pand…
913cf0e 
…as-dev#52921)

Revert "DEPR: DataFrameGroupBy.apply operating on the group keys (pandas-dev#52477)"

This reverts commit 9b20759.
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@rhshadrach
DEPR: Revert DataFrameGroupBy.apply operating on the group keys (pand…
b14ccea 
…as-dev#52921)

Revert "DEPR: DataFrameGroupBy.apply operating on the group keys (pandas-dev#52477)"

This reverts commit 9b20759.
@rhshadrach rhshadrach mentioned this pull request Sep 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rhshadrach @phofl @mroeschke