Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test groupby for columns with string objects #52757

Merged
merged 3 commits into from
Apr 22, 2023
Merged

TST: Test groupby for columns with string objects #52757

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c9b0f1
GH-24196: regression test on sum nan implemented
gmaiwald Apr 18, 2023
132f0e8
GH-24196: typo fixed
gmaiwald Apr 18, 2023
3e10c6a
GH-24196: linting rules applied
gmaiwald Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2970,3 +2970,14 @@ def test_groupby_numeric_only_std_no_result(numeric_only):
ValueError, match="could not convert string to float: 'bar'"
):
dfgb.std(numeric_only=numeric_only)


@pytest.mark.parametrize("bug_var", [1, "a"])
def test_groupby_sum_on_nan_should_return_nan(bug_var):
# GH 24196
df = DataFrame({"A": [bug_var, bug_var, bug_var, np.nan]})
dfgb = df.groupby(lambda x: x)
result = dfgb.sum(min_count=1)

expected_df = DataFrame([bug_var, bug_var, bug_var, np.nan], columns=["A"])
tm.assert_frame_equal(result, expected_df)