Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing: Narrow down types of arguments (NDFrame) #52756

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

kevinanker
Copy link
Contributor

@kevinanker kevinanker commented Apr 18, 2023

Updated item 11-14 (15 seemed already done):

  • Specify method in to_sql more precisely
  • Specify errors in to_csv more precisely
  • Specify mode in to_csv more precisely
  • Specify kind and na_position in sort_values more precisely

@kevinanker kevinanker changed the title Improve typing nd frame Typing: Narrow down types of arguments (NDFrame) Apr 18, 2023
@kevinanker
Copy link
Contributor Author

@phofl @noatamir

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@noatamir
Copy link
Member

Thanks for the PR @kjanker! There are a couple of errors identified by pre-commit, which I think you can solve yourself. Let me know if you need help understanding the errors.

pandas/core/generic.py Outdated Show resolved Hide resolved
@twoertwein twoertwein merged commit 433f34b into pandas-dev:main Apr 19, 2023
@twoertwein
Copy link
Member

Thanks @kjanker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants