Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed str to literal in inteprolate and limit_direction #52755

Merged
merged 1 commit into from
Apr 19, 2023
Merged

changed str to literal in inteprolate and limit_direction #52755

merged 1 commit into from
Apr 19, 2023

Conversation

VanMyHu
Copy link
Contributor

@VanMyHu VanMyHu commented Apr 18, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@VanMyHu
Copy link
Contributor Author

VanMyHu commented Apr 18, 2023

Worked on Issue 10 for the following points:

  • Specify method in interpolate more precisely
  • Specify limit_direction in interpolate more precisely

Please review the code: @phofl, @noatamir, @jorisvandenbossche, @MarcoGorelli

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
@twoertwein twoertwein merged commit b05a6c2 into pandas-dev:main Apr 19, 2023
@twoertwein
Copy link
Member

Thanks @VanMyHu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VanMyHu @twoertwein @noatamir