Typing: Narrow down types of arguments (NDFrame) #10 #52754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
requested changes
Apr 18, 2023
pandas/core/generic.py
Outdated
| @@ -2276,7 +2276,7 @@ def to_json( | |||
| date_format: str | None = None, | |||
| double_precision: int = 10, | |||
| force_ascii: bool_t = True, | |||
| date_unit: str = "ms", | |||
| date_unit: Literal["s", "ms", "us", "ns"] = "ms", | |||
There was a problem hiding this comment.
this one seems broadly useful - perhaps let's define it as TimeUnit in _typing.py and import it here?
pandas/core/generic.py
Outdated
| complevel: int | None = None, | ||
| complib: str | None = None, | ||
| complib: ["zlib", "lzo", "bzip2", "blosc"] | None = None, |
There was a problem hiding this comment.
change addressed problems
|
Thanks for the PR @mKlepsch! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help. |
|
Hope it works now! |
removed the new line in the import
|
Hi, I can't figure out why it is still failing the CI. Could you give me some pointers? |
|
you'll need to run the pre-commit hooks, please check the contributing guide for how to do that |
|
You can do: (It's probably a space at the end of the line, which is disallowed |
phofl
reviewed
Apr 22, 2023
mroeschke
approved these changes
Apr 24, 2023
phofl
approved these changes
Apr 24, 2023
|
Thanks @mKlepsch |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…s-dev#52754) * improved specificationfor date_unit in to_json more precisely * improved specification mode in to_hdf * added the Literal to complib of to_hdf * improved format for to_hdf * address PR review * Update generic.py removed the new line in the import * ran "pre-commit" to fix trailing whitespace
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…s-dev#52754) * improved specificationfor date_unit in to_json more precisely * improved specification mode in to_hdf * added the Literal to complib of to_hdf * improved format for to_hdf * address PR review * Update generic.py removed the new line in the import * ran "pre-commit" to fix trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing: Narrow down types of arguments (NDFrame) #10
Made these specifications to Literals:
@phofl @jorisvandenbossche @noatamir @MarcoGorelli