Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: disallow constructing Period with freq=C #52567

Merged
merged 2 commits into from
Apr 11, 2023
Merged

BUG: disallow constructing Period with freq=C #52567

merged 2 commits into from
Apr 11, 2023
+25 −1

Conversation

jbrockmendel
Copy link
Member

mroeschke
mroeschke reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CustomBusinessHour/MonthEnd/MonthBegin already disallowed?

@mroeschke mroeschke added Frequency DateOffsets Period Period data type labels Apr 10, 2023
@jbrockmendel
Copy link
Member Author

Are CustomBusinessHour/MonthEnd/MonthBegin already disallowed?

yes

@mroeschke mroeschke added this to the 2.1 milestone Apr 11, 2023
@mroeschke mroeschke merged commit 7187e67 into pandas-dev:main Apr 11, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-52534 branch April 11, 2023 00:41
@natmokval natmokval mentioned this pull request Nov 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Frequency DateOffsets Period Period data type
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG?: Period allows construction from Custom freqs
2 participants
@jbrockmendel @mroeschke