REF: Use _python_apply_general internally #52342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Refactor
jbrockmendel
reviewed
Apr 1, 2023
|
|
||
| def __getattr__(self, name: str): | ||
| def attr(*args, **kwargs): | ||
| def f(self): | ||
| return getattr(self.plot, name)(*args, **kwargs) | ||
|
|
||
| return self._groupby.apply(f) | ||
| return self._groupby._python_apply_general(f, self._groupby._selected_obj) |
There was a problem hiding this comment.
does selected_obj vs obj_with_exclusions matter here? think we're mostly standardizing on the latter
There was a problem hiding this comment.
Yes - this is preserving current behavior that will then be deprecated (#7155). Enforcing that deprecation will allow us to use obj_with_exclusions.
5 tasks
mroeschke
approved these changes
Apr 6, 2023
|
Thanks @rhshadrach |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.For #7155, avoiding calling the public
.applyto raise deprecation warnings.