Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add explanation how to convert arrow table to pandas df #51762

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 3, 2023

@phofl phofl requested a review from datapythonista March 3, 2023 16:10
@phofl phofl added Docs Arrow pyarrow functionality labels Mar 3, 2023
@phofl phofl added this to the 2.0 milestone Mar 3, 2023
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as discussed in #51769, we can implement DataFrame.from_arrow, which is probably easier to expect and remember by users. Maybe let's leave this open for now, in case there is an issue with that, but I guess we can implement this paragraph and example with the from_arrow idiom in that other PR.

@phofl
Copy link
Member Author

phofl commented Mar 4, 2023

Not totally sure, maybe it's better for now to expected users to be explicit when converting? I think we can expected users that have arrow tables to be aware of the to_pandas method?

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #51769 seems to have mixed feelings currently I'd be okay with adding this note in the meantime

@datapythonista datapythonista merged commit 7b855c1 into pandas-dev:main Mar 7, 2023
@datapythonista
Copy link
Member

Thanks @phofl, this is useful

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 7, 2023
phofl added a commit that referenced this pull request Mar 7, 2023
…rt arrow table to pandas df) (#51822)

Backport PR #51762: DOC: Add explanation how to convert arrow table to pandas df

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the doc_pyarrow_table branch March 7, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to convert Arrow tables to Arrow-backed dataframes
3 participants