CI: Change development python version to 3.10 #51133

phofl · 2023-02-02T23:16:16Z

closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Mypy passes locally now. Lets see if ci passes as well.

github-actions · 2023-03-25T00:05:27Z

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

# Conflicts: # pandas/core/generic.py # pandas/tests/indexes/datetimes/test_constructors.py # pyproject.toml

phofl · 2023-04-09T20:22:59Z

/preview

github-actions · 2023-04-09T20:23:10Z

Website preview of this PR available at: https://pandas.pydata.org/preview/51133/

phofl · 2023-04-09T20:33:22Z

cc @mroeschke any idea why it's not including the Series.dt file?

mroeschke · 2023-04-10T16:44:43Z

It looks like it's being included in https://pandas.pydata.org/preview/51133/docs/reference/api/pandas.Series.dt.date.html?

phofl · 2023-04-10T16:57:09Z

I meant https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.html in our current docs. Sphinx raises a warning that the document isn't included in any toctree. the str and cat accessors work

mroeschke · 2023-04-10T17:46:32Z

Ah hmm yeah I'm not too sure off the top of my head why it's not included. None of the sphinx versions changed with the bump right?

phofl · 2023-04-12T23:11:08Z

No they are the same. This is really weird, the inheritance logic is a bit weird for the date accessor, so I think that's the problem. Would you be ok with merging anyway?

# Conflicts: # ci/deps/actions-38.yaml

# Conflicts: # .github/workflows/macos-windows.yml # .github/workflows/ubuntu.yml

mroeschke · 2023-04-25T01:05:51Z

.github/workflows/wheels.yml

@@ -55,7 +55,7 @@ jobs:
        - [windows-2019, win_amd64]
        - [windows-2019, win32]
        # TODO: support PyPy?
-        python: [["cp38", "3.8"], ["cp39", "3.9"], ["cp310", "3.10"],  ["cp311", "3.11"]]# "pp38", "pp39"]
+        python: [["cp39", "3.9"], ["cp310", "3.10"],  ["cp311", "3.11"]]# "pp38", "pp39"]


Suggested change

python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp38", "pp39"]

python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp39"]

mroeschke · 2023-04-25T01:06:44Z

doc/source/conf.py

@@ -76,6 +76,7 @@
    # to ensure that include files (partial pages) aren't built, exclude them
    # https://github.com/sphinx-doc/sphinx/issues/1965#issuecomment-124732907
    "**/includes/**",
+    "**/api/pandas.Series.dt.rst",


Just a reminder to open an issue about this once we merge this

Yep, it's on my todo list

mroeschke · 2023-04-25T01:08:42Z

This would need a whatsnew in 2.1 that 3.8 support has been dropped

mroeschke · 2023-04-25T01:13:48Z

Some grepped results where we still mention 3.8

./doc/source/getting_started/install.rst:Officially Python 3.8, 3.9, 3.10 and 3.11.
./doc/source/development/contributing_gitpod.rst:We have built a python 3.8 environment and all development dependencies will

phofl · 2023-04-25T20:04:16Z

Thx, completely forgot the docs. Updated

lithomas1

LGTM. Are you going to remove pandas.compat.PY39 as well here or in a followup?

phofl · 2023-04-26T12:12:08Z

This is getting bigger and bigger (underestimated it when starting to rip out 3.8), would prefer merging and then doing the rest as follow ups

lithomas1 · 2023-04-26T14:30:41Z

Sounds good to me.
thanks @phofl

* CI: Change development python version to 3.10 * Update checks * Remove strict * Remove strict * Fixes * Add dt * Switch python to 3.9 * Remove * Fix * Try attribute * Adjust * Fix mypy * Try fixing doc build * Fix mypy * Fix stubtest * Remove workflow file * Rename back * Update * Rename * Rename * Change python version * Remove * Fix doc errors * Remove pypy * Update ci/deps/actions-pypy-39.yaml Co-authored-by: Thomas Li <[email protected]> * Revert pypy removal * Remove again * Fix * Change to 3.9 * Address --------- Co-authored-by: Thomas Li <[email protected]>

* ENH: better dtype inference when doing DataFrame reductions * precommit issues * fix failures * fix failures * mypy + some docs * doc linting linting * refactor to use _reduce_with_wrap * docstring linting * pyarrow failure + linting * pyarrow failure + linting * linting * doc stuff * linting fixes * fix fix doc string * remove _wrap_na_result * doc string example * pyarrow + categorical * silence bugs * silence errors * silence errors II * fix errors III * various fixups * various fixups * delay fixing windows and 32bit failures * BUG: Adding a columns to a Frame with RangeIndex columns using a non-scalar key (#52877) * DOC: Update whatsnew (#52882) * CI: Change development python version to 3.10 (#51133) * CI: Change development python version to 3.10 * Update checks * Remove strict * Remove strict * Fixes * Add dt * Switch python to 3.9 * Remove * Fix * Try attribute * Adjust * Fix mypy * Try fixing doc build * Fix mypy * Fix stubtest * Remove workflow file * Rename back * Update * Rename * Rename * Change python version * Remove * Fix doc errors * Remove pypy * Update ci/deps/actions-pypy-39.yaml Co-authored-by: Thomas Li <[email protected]> * Revert pypy removal * Remove again * Fix * Change to 3.9 * Address --------- Co-authored-by: Thomas Li <[email protected]> * update * update * add docs * fix windows tests * fix windows tests * remove guards for 32bit linux * add bool tests + fix 32-bit failures * fix pre-commit failures * fix mypy failures * rename _reduce_with -> _reduce_and_wrap * assert missing attributes * reduction dtypes on windows and 32bit systems * add tests for min_count=0 * PERF:median with axis=1 * median with axis=1 fix * streamline Block.reduce * fix comments * FIX preserve dtype with datetime columns of different resolution when merging (#53213) * BUG Merge not behaving correctly when having `MultiIndex` with a single level (#53215) * fix merge when MultiIndex with single level * resolved conversations * fixed code style * BUG: preserve dtype for right/outer merge of datetime with different resolutions (#53233) * remove special BooleanArray.sum method * remove BooleanArray.prod * fixes * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Joris Van den Bossche <[email protected]> * Update pandas/core/array_algos/masked_reductions.py Co-authored-by: Joris Van den Bossche <[email protected]> * small cleanup * small cleanup * only reduce 1d * fix after #53418 * update according to comments * revome note * update _minmax * REF: add keepdims parameter to ExtensionArray._reduce + remove ExtensionArray._reduce_and_wrap * REF: add keepdims parameter to ExtensionArray._reduce + remove ExtensionArray._reduce_and_wrap * fix whatsnew * fix _reduce call * simplify test * add tests for any/all --------- Co-authored-by: Patrick Hoefler <[email protected]> Co-authored-by: Thomas Li <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Yao Xiao <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]>

phofl added 2 commits February 3, 2023 00:12

CI: Change development python version to 3.10

638b578

Update checks

9c9b3ad

phofl marked this pull request as draft February 2, 2023 23:16

phofl added 8 commits February 3, 2023 00:23

Remove strict

7fb6db9

Remove strict

e67c34c

Fixes

2075191

Add dt

1ad202f

Switch python to 3.9

2301bd5

Remove

bec8bbb

Fix

3779b01

Try attribute

c0bf945

simonjayhawkins added the CI Continuous Integration label Feb 22, 2023

github-actions bot added the Stale label Mar 25, 2023

Merge remote-tracking branch 'upstream/main' into 310

598726e

# Conflicts: # pandas/core/generic.py # pandas/tests/indexes/datetimes/test_constructors.py # pyproject.toml

phofl mentioned this pull request Apr 7, 2023

DEV: Upgrade Python development version to 3.9/3.10 #52513

Closed

phofl and others added 2 commits April 7, 2023 17:35

Adjust

19e22f6

Merge branch 'main' into 310

0b0901d

mroeschke removed the Stale label Apr 7, 2023

phofl and others added 4 commits April 9, 2023 17:53

Fix mypy

93d475e

Merge branch 'main' into 310

f92fd7b

Try fixing doc build

60a6ad5

Fix mypy

f0d47ac

phofl and others added 6 commits April 23, 2023 12:04

Merge remote-tracking branch 'upstream/main' into 310

e6c60d8

# Conflicts: # ci/deps/actions-38.yaml

Remove again

9ad3cf4

Merge branch 'main' into 310

7169faf

Merge remote-tracking branch 'upstream/main' into 310

11a8c48

# Conflicts: # .github/workflows/macos-windows.yml # .github/workflows/ubuntu.yml

Fix

9b2c7f7

Change to 3.9

bb1b5b7

mroeschke reviewed Apr 25, 2023

View reviewed changes

phofl added 2 commits April 25, 2023 22:03

Address

df5f011

Merge remote-tracking branch 'upstream/main' into 310

d3089cc

mroeschke approved these changes Apr 25, 2023

View reviewed changes

mroeschke added this to the 2.1 milestone Apr 25, 2023

mroeschke added the Dependencies Required and optional dependencies label Apr 25, 2023

lithomas1 approved these changes Apr 26, 2023

View reviewed changes

lithomas1 merged commit 3968484 into pandas-dev:main Apr 26, 2023

phofl deleted the 310 branch April 26, 2023 15:52

phofl mentioned this pull request Apr 26, 2023

DOC: Series.dt currently not included in docs on main #52937

Closed

1 task

rhshadrach mentioned this pull request Apr 30, 2023

CI: Update Python version for ASVs #53012

Merged

5 tasks

anmyachev mentioned this pull request May 25, 2023

FEAT-#5936: support pandas 2.0.2 modin-project/modin#5995

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Change development python version to 3.10 #51133

CI: Change development python version to 3.10 #51133

phofl commented Feb 2, 2023

github-actions bot commented Mar 25, 2023

phofl commented Apr 9, 2023

github-actions bot commented Apr 9, 2023

phofl commented Apr 9, 2023

mroeschke commented Apr 10, 2023

phofl commented Apr 10, 2023

mroeschke commented Apr 10, 2023

phofl commented Apr 12, 2023

mroeschke Apr 25, 2023

mroeschke Apr 25, 2023

phofl Apr 25, 2023

mroeschke commented Apr 25, 2023

mroeschke commented Apr 25, 2023

phofl commented Apr 25, 2023

lithomas1 left a comment

phofl commented Apr 26, 2023

lithomas1 commented Apr 26, 2023

	python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp38", "pp39"]
	python: [["cp39", "3.9"], ["cp310", "3.10"], ["cp311", "3.11"]]# "pp39"]

CI: Change development python version to 3.10 #51133

CI: Change development python version to 3.10 #51133

Conversation

phofl commented Feb 2, 2023

github-actions bot commented Mar 25, 2023

phofl commented Apr 9, 2023

github-actions bot commented Apr 9, 2023

phofl commented Apr 9, 2023

mroeschke commented Apr 10, 2023

phofl commented Apr 10, 2023

mroeschke commented Apr 10, 2023

phofl commented Apr 12, 2023

mroeschke Apr 25, 2023

Choose a reason for hiding this comment

mroeschke Apr 25, 2023

Choose a reason for hiding this comment

phofl Apr 25, 2023

Choose a reason for hiding this comment

mroeschke commented Apr 25, 2023

mroeschke commented Apr 25, 2023

phofl commented Apr 25, 2023

lithomas1 left a comment

Choose a reason for hiding this comment

phofl commented Apr 26, 2023

lithomas1 commented Apr 26, 2023