BUG: astype to string modifying input array inplace #51073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/string_.py
Outdated
| # modifying input inplace | ||
| inferred = lib.infer_dtype(scalars, skipna=False) | ||
| if inferred != "string": | ||
| copy = True | ||
| result = lib.ensure_string_array(scalars, na_value=libmissing.NA, copy=copy) |
There was a problem hiding this comment.
can we do this fix in ensure_string_array? ive been hoping to simplify it to make it always take an ndarray.
There was a problem hiding this comment.
Yep sure, was not sure if this was intended or not. Moved to Cython and improved performance as well
mroeschke
added
Dtype Conversions
mroeschke
approved these changes
Feb 1, 2023
jorisvandenbossche
approved these changes
Feb 1, 2023
|
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.inferring is faster than copying in all cases.