Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: to_dict not converting NA to None #50796

Merged
merged 2 commits into from
Jan 18, 2023
Merged

BUG: to_dict not converting NA to None #50796

merged 2 commits into from
Jan 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 17, 2023

@phofl phofl added IO Data IO issues that don't fit into a more specific label Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jan 17, 2023
mroeschke
mroeschke approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phofl phofl added this to the 2.0 milestone Jan 18, 2023
@phofl phofl merged commit b888dad into pandas-dev:main Jan 18, 2023
@phofl phofl deleted the to_dict_na branch January 18, 2023 09:00
@lukemanley
Copy link
Member

Should this change be made more broadly? (e.g. tolist, iteration) - see discussion in #29738

@mroeschke
Copy link
Member

I would think so, yes

@lukemanley lukemanley mentioned this pull request Jan 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO Data IO issues that don't fit into a more specific label Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: to_dict should convert NA to None
3 participants
@phofl @lukemanley @mroeschke