TST: Add a test for fillna in PeriodArray #50671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mstazherova
commented
Jan 10, 2023
mstazherova
commented
- closes Float conversion makes fillna lossy #24537
mstazherova
force-pushed
the
GH-24537/parr-fillna-test
branch
from
e1caeb1 to
786f288
Compare
mstazherova
force-pushed
the
GH-24537/parr-fillna-test
branch
2 times, most recently
from
b99e457 to
9f5c054
Compare
phofl
reviewed
Jan 11, 2023
phofl
reviewed
Jan 12, 2023
mstazherova
force-pushed
the
GH-24537/parr-fillna-test
branch
from
ad941d7 to
6085795
Compare
mstazherova
force-pushed
the
GH-24537/parr-fillna-test
branch
from
6085795 to
5f494f0
Compare
|
@phofl should I still do something before this PR can be merged? Right now it's failing on pre-commit, but it's not related to my changes. |
simonjayhawkins
changed the title
|
Sorry, was a bit busy yesterday. pre-commit is failing, otherwise this lgtm |
|
Looks like pre-commit failure came from something else, merged main to check |
phofl
approved these changes
Jan 15, 2023
|
thx @mstazherova |
|
Cool, thank you! Excited to do more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.