Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Temporary pin sqlalchemy #50591

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 5, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

looks like it's quite tricky to fix the sqlalchemy issues, so perhaps it's OK to just pin temporarily to get CI green again?

@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Jan 5, 2023
@phofl
Copy link
Member

phofl commented Jan 5, 2023

I am quite optimistic that mine is ready now, but lets see what the ci says

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this to get ci green, Ubuntu jobs are timing out on the other pr

@phofl phofl changed the title tmp pin sqlalchemy CI: Temporary pin sqlalchemy Jan 6, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 6, 2023 10:54
@MarcoGorelli MarcoGorelli merged commit fa78ea8 into pandas-dev:main Jan 6, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 6, 2023
@MarcoGorelli
Copy link
Member Author

@meeseeksdev please backport to 1.5.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 6, 2023
MarcoGorelli added a commit that referenced this pull request Jan 6, 2023
…0602)

Backport PR #50591: CI: Temporary pin sqlalchemy

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants