ER: give a better error message for hashing indices #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -600,7 +600,7 @@ def __contains__(self, key): | |||
| return False | |||
|
|
|||
| def __hash__(self): | |||
| return hash(self.view(np.ndarray)) | |||
There was a problem hiding this comment.
is this actually used anywhere? or just provided for compat?
There was a problem hiding this comment.
it raises the same TypeError as my change does, but my change shows the subclass name
There was a problem hiding this comment.
hash raise test has been around since june 23 2011, incidentally that's my birthday
|
ok...then |
cpcloud
added a commit
that referenced
this pull request
Sep 28, 2013
ER: give a better error message for hashing indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.