ENH: infer Timestamp(iso8601string) resolution #49737
Conversation
mroeschke
added
Non-Nano
im pretty sure we have loads of these, unless we're thinking of different things. you mean like "2016-01-01 04:05:06-01:00" right? |
Yeah exactly. Should those test assert that the resolution is a certain value too? |
There was a problem hiding this comment.
LGTM (I think the failure are unrelated) Merge when ready @MarcoGorelli
| obj.value = tz_localize_to_utc_single( | ||
| value, obj.tzinfo, ambiguous=None, nonexistent=None, creso=reso | ||
| ) | ||
| obj.creso = reso |
There was a problem hiding this comment.
this is for use by ensure_reso?
| return convert_to_tsobject(ival, tz, None, False, False) | ||
| ival = tz_localize_to_utc_single( | ||
| ival, tz, ambiguous="raise", nonexistent=None, creso=reso | ||
| ) | ||
| obj = _TSObject() | ||
| obj.dts = dts | ||
| obj.value = ival | ||
| obj.creso = reso | ||
| maybe_localize_tso(obj, tz, obj.creso) | ||
| return obj |
There was a problem hiding this comment.
is this because convert_to_tsobject doesn't (yet?) allow passing a reso to set before calling maybe_localize_tso?
There was a problem hiding this comment.
some combination of that and me not wanting to recurse. honestly i dont remember how much of each off the top of my head
| elif ( | ||
| isinstance(tz, tzlocal) | ||
| and is_platform_windows() | ||
| and _offset in (QuarterEnd, BQuarterBegin, BQuarterEnd) | ||
| ): | ||
| request.node.add_marker( | ||
| pytest.mark.xfail(reason="After GH#49737 t.tzinfo is None on CI") | ||
| ) |
There was a problem hiding this comment.
I'm confused - the xfail reason only mentions t.tzinfo, and the if-statement condition depends on _offset, yet t = Timestamp("20080101", tz=tz) doesn't depend on _offset, why's that?
There was a problem hiding this comment.
best guess is some kind of windows-themed demon trying to increase my blood pressure. seriously i couldn't reproduce it so just punted.
There was a problem hiding this comment.
OK, no objections. I don't think I've ever seen anyone use tz_local anyway
|
looks good - merging then, thanks @jbrockmendel ! |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.