STYLE/PERF: replace string concatenations with f-strings in core #49518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
string-concatenations-core
branch
from
71435e2 to
a7f3ce0
Compare
akx
force-pushed
the
string-concatenations-core
branch
from
a7f3ce0 to
9d1591b
Compare
|
Thanks @akx! |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing less concatenations and explicit cast calls in the core is likely to yield some performance improvements (see https://twitter.com/raymondh/status/1205969258800275456).
Split out of #49229.
Refs #29547 (a 2019 issue tracking replacing formatting with better alternatives)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.