-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: MultiIndex.join does not work for ea dtypes #49284
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6015196
REGR: MultiIndex.join does not work for ea dtypes
phofl 1c070f4
Merge remote-tracking branch 'upstream/main' into 49277
phofl a20177b
Update base.py
phofl 556a8e4
Merge branch 'main' into 49277
phofl 885eb18
Merge remote-tracking branch 'upstream/main' into 49277_tmp
phofl 65b8c7b
Merge branch 'main' into 49277
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4636,8 +4636,9 @@ def join( | |
return self._join_non_unique(other, how=how) | ||
elif not self.is_unique or not other.is_unique: | ||
if self.is_monotonic_increasing and other.is_monotonic_increasing: | ||
if self._can_use_libjoin: | ||
if not is_interval_dtype(self.dtype): | ||
# otherwise we will fall through to _join_via_get_indexer | ||
# go through object dtype for ea till engine is supported properly | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we have a GH issue related to an engine for EAs? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return self._join_monotonic(other, how=how) | ||
else: | ||
return self._join_non_unique(other, how=how) | ||
|
@@ -5012,7 +5013,7 @@ def _wrap_joined_index(self: _IndexT, joined: ArrayLike, other: _IndexT) -> _Ind | |
return self._constructor(joined, name=name) # type: ignore[return-value] | ||
else: | ||
name = get_op_result_name(self, other) | ||
return self._constructor._with_infer(joined, name=name) | ||
return self._constructor._with_infer(joined, name=name, dtype=self.dtype) | ||
|
||
@cache_readonly | ||
def _can_use_libjoin(self) -> bool: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
_can_use_libjoin
shouldn't be updated instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, in most cases going through object dtype is slower than the alternative. In our case here the alternative can not handle non interval dtype