BUG: ensure object dtype for strftime accessor/index method + REGR: avoid spurious warning #48147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void spurious warning
| @@ -116,7 +116,7 @@ def _new_DatetimeIndex(cls, d): | |||
| + [ | |||
| method | |||
| for method in DatetimeArray._datetimelike_methods | |||
| if method not in ("tz_localize", "tz_convert") | |||
| if method not in ("tz_localize", "tz_convert", "strftime") | |||
There was a problem hiding this comment.
strftime was added as an explicit method instead of automatically delegated one in #36742 (the method below where I edited the return value), but at that time we forgot to correctly remove it from this list
TomAugspurger
approved these changes
Aug 19, 2022
mroeschke
approved these changes
Aug 19, 2022
|
Thanks @jorisvandenbossche (failure unrelated) |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 19, 2022
…ccessor/index method + REGR: avoid spurious warning
phofl
pushed a commit
that referenced
this pull request
Aug 19, 2022
…time accessor/index method + REGR: avoid spurious warning) (#48158)
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…void spurious warning (pandas-dev#48147)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.