BUG: Fixed ignoring of nanoseconds when adding to series #47856 #48008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While working on this, I also fixed a couple typos I noticed along the way. |
mroeschke
reviewed
Aug 8, 2022
mroeschke
reviewed
Aug 8, 2022
| # GH 47856 | ||
| t = Timestamp("2022-01-01") | ||
| teststamp = t | ||
| s = Series([t]) |
There was a problem hiding this comment.
Nit: Could you avoid one letter names?
mroeschke
added
Numeric Operations
Co-authored-by: Matthew Roeschke <[email protected]>
…to timedelta-bug
mroeschke
reviewed
Aug 9, 2022
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -1157,7 +1157,9 @@ cdef class RelativeDeltaOffset(BaseOffset): | |||
| return dt64other | |||
| elif not self._use_relativedelta and hasattr(self, "_offset"): | |||
| # timedelta | |||
| delta = Timedelta(self._offset * self.n) | |||
| num_nano = getattr(self, "nanoseconds", 0) | |||
| rem_nano = Timedelta(nanoseconds=num_nano) | |||
There was a problem hiding this comment.
I think for performance reasons, it would be good to only construct the Timedelta and add to the offset if nanoseconds != 0
mroeschke
reviewed
Aug 9, 2022
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -1157,7 +1157,11 @@ cdef class RelativeDeltaOffset(BaseOffset): | |||
| return dt64other | |||
| elif not self._use_relativedelta and hasattr(self, "_offset"): | |||
| # timedelta | |||
| delta = Timedelta(self._offset * self.n) | |||
| if hasattr(self, "nanoseconds"): | |||
There was a problem hiding this comment.
Nit: Could you use the getattr and check for != 0 instead?
mroeschke
reviewed
Aug 9, 2022
Co-authored-by: Matthew Roeschke <[email protected]>
…to timedelta-bug
mroeschke
approved these changes
Aug 10, 2022
|
Thanks @srotondo |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…7856 (pandas-dev#48008) * BUG: Fixed ignoring of nanoseconds when adding to series pandas-dev#47856 * Update doc/source/whatsnew/v1.5.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * BUG: Renamed test variables pandas-dev#47856 * BUG: Changed added if-else for performance pandas-dev#47856 * Update pandas/_libs/tslibs/offsets.pyx Co-authored-by: Matthew Roeschke <[email protected]> * BUG: Used getattr for nano check pandas-dev#47856 Co-authored-by: Steven Rotondo <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanosecondsin pd.DateOffset was ignored when add to pd.Series #47856 (Replace xxxx with the Github issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.