Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: GH39984 Addition to tests #47981

Closed

Conversation

BarkotBeyene
Copy link
Contributor

@BarkotBeyene BarkotBeyene commented Aug 5, 2022

@pep8speaks
Copy link

pep8speaks commented Aug 5, 2022

Hello @BarkotBeyene! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-11 21:39:20 UTC

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run pre-commit locally to fix errors?

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Aug 8, 2022
@@ -647,6 +648,22 @@ def test_from_frame():
result = MultiIndex.from_frame(df)
tm.assert_index_equal(expected, result)

def test_from_frame_multiIndex():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to a pytest.mark.skipif(pa_version_under1p01) decorator here to skip if pyarrow is not installed

@mroeschke
Copy link
Member

Looks like a duplicate of #48042 so closing

@mroeschke mroeschke closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unable to create a MultiIndex with nan values in nullable Float dtypes
4 participants