-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYP: Update timestamps.pyi #47756
TYP: Update timestamps.pyi #47756
Conversation
Thanks @hauntsaninja! I assume you use the not-yet-released mypy 0.970? When I run I only get error: not checking stubs due to mypy build errors:
pandas/core/indexes/base.py:7138: error: Cannot determine type of "argmin" [has-type]
pandas/core/indexes/base.py:7150: error: Cannot determine type of "argmax" [has-type]
pandas/core/window/rolling.py:1842: error: Unused "type: ignore" comment
pandas/core/window/rolling.py:1848: error: Unused "type: ignore" comment Seems there are some type errors: |
I used mypy==0.960 for this, but did a couple unconventional things to get things running :-) I'll file an issue for running stubtest in CI and help get it integrated properly. Btw, what is the relationship between the stubs in pandas-dev/pandas.git and the stubs in pandas-dev/pandas-stubs.git? |
Ideally, they should be the same (and I hope that in the future they are the same). In many cases, pandas and pandas-stubs are/will hopefully be aligned but in certain cases, it is impossible(?) to find a "good" annotation. For pandas-stubs, "good" roughly means it works for users. For pandas, "good" roughly means what is technically possible (e.g., |
Thank you @hauntsaninja! |
No description provided.