BUG: read_excel raising uncontrolled IndexError when header references non-existing rows #47399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s non-existing rows
phofl
added
Error Reporting
rhshadrach
reviewed
Jun 20, 2022
pandas/io/excel/_base.py
Outdated
| @@ -774,6 +774,11 @@ def parse( | |||
| assert isinstance(skiprows, int) | |||
| row += skiprows | |||
|
|
|||
| if row > len(data) - 1: | |||
| raise ValueError( | |||
| f"Header index {row} references non-existing rows.", | |||
There was a problem hiding this comment.
Would it be helpful to report the number of rows? E.g.
f"header index {row} exceeds maximum index {len(data) - 1} of data.",
I also made the h lowercase to match the argument header to read_excel.
mroeschke
approved these changes
Jun 21, 2022
|
Thanks @phofl |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…s non-existing rows (pandas-dev#47399) * BUG: read_excel raising uncontrolled IndexError when header references non-existing rows * Fix issue number * Change message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.