Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Debug Windows stack overflow #46358

Merged
merged 8 commits into from
Mar 15, 2022
Merged

Conversation

mroeschke
Copy link
Member

Thread 0x0000142c (most recent call first):
  File "C:\Miniconda\en.vs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 400 in read
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 432 in from_io
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 967 in _thread_receiver
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 220 in run
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 285 in _perform_spawn

Current thread 0x00000520 (most recent call first):
  File "D:\a\1\s\pandas\core\construction.py", line 850 in is_empty_data
  File "D:\a\1\s\pandas\core\construction.py", line 887 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__
  File "D:\a\1\s\pandas\core\construction.py", line 889 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__
  File "D:\a\1\s\pandas\core\construction.py", line 889 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__

@mroeschke mroeschke marked this pull request as draft March 13, 2022 18:16
@mroeschke mroeschke added this to the 1.5 milestone Mar 14, 2022
@mroeschke mroeschke marked this pull request as ready for review March 14, 2022 01:52
@mroeschke mroeschke added the CI Continuous Integration label Mar 14, 2022
@mroeschke mroeschke marked this pull request as draft March 14, 2022 03:36
@jbrockmendel
Copy link
Member

@mroeschke LMK if extra eyeballs can be made helpful here

@mroeschke
Copy link
Member Author

@jbrockmendel thanks that would be helpful. Here's the logs of the crashing build (gw1 is crashing)

https://dev.azure.com/pandas-dev/e01c9671-576d-40f3-a1a1-7bef78604087/_apis/build/builds/75338/logs/45

From what I've deduced, something changed such that recursion in our test suite leads to stack overflows in Windows. Appears there might be another one somewhere in pandas/tests/extension but not exactly sure where

@mroeschke mroeschke marked this pull request as ready for review March 14, 2022 22:53
@mroeschke
Copy link
Member Author

@jbrockmendel look okay to you?

@jbrockmendel
Copy link
Member

not wild about the is_ci_environment part but dont have any better ideas. LGTM

@mroeschke mroeschke merged commit 46d0075 into pandas-dev:main Mar 15, 2022
@mroeschke
Copy link
Member Author

Thanks @jbrockmendel yeah same. I have no idea why Windows is acting different suddenly but with is_ci_environment hopefully people can still check the test locally.

@mroeschke mroeschke deleted the ci/debug/windows branch March 15, 2022 19:44
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 29, 2022
@simonjayhawkins simonjayhawkins modified the milestones: 1.5, 1.4.2 Mar 29, 2022
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Mar 29, 2022
* CI: Debug Windows stack overflow

* Set recursion limit for some tests

* Remove pytest azurepipelines causing issues with 32 bit build?

* Remove -v

* Debug again

* Fix invocation

* TestReduceBoolean causing this?

* Remove -v
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* CI: Debug Windows stack overflow

* Set recursion limit for some tests

* Remove pytest azurepipelines causing issues with 32 bit build?

* Remove -v

* Debug again

* Fix invocation

* TestReduceBoolean causing this?

* Remove -v
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants