-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Debug Windows stack overflow #46358
Conversation
mroeschke
commented
Mar 13, 2022
@mroeschke LMK if extra eyeballs can be made helpful here |
@jbrockmendel thanks that would be helpful. Here's the logs of the crashing build (gw1 is crashing) From what I've deduced, something changed such that recursion in our test suite leads to stack overflows in Windows. Appears there might be another one somewhere in |
@jbrockmendel look okay to you? |
not wild about the is_ci_environment part but dont have any better ideas. LGTM |
Thanks @jbrockmendel yeah same. I have no idea why Windows is acting different suddenly but with is_ci_environment hopefully people can still check the test locally. |
@meeseeksdev backport 1.4.x |
* CI: Debug Windows stack overflow * Set recursion limit for some tests * Remove pytest azurepipelines causing issues with 32 bit build? * Remove -v * Debug again * Fix invocation * TestReduceBoolean causing this? * Remove -v
* CI: Debug Windows stack overflow * Set recursion limit for some tests * Remove pytest azurepipelines causing issues with 32 bit build? * Remove -v * Debug again * Fix invocation * TestReduceBoolean causing this? * Remove -v