Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: xfail geopandas downstream test on MacOS due to fiona install #46296

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

mroeschke
Copy link
Member

Not really familiar with geopandas to know why this install fails on MacOS, so xfailing for now (maybe there's a more lightweight test that doesn't read a file?)

cc @jorisvandenbossche

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=75056&view=logs&jobId=b1891a80-bdb0-5193-5f59-ce68a0874df0&j=b1891a80-bdb0-5193-5f59-ce68a0874df0&t=0a58a9e9-0673-539c-5bde-d78a5a3b655e

=================================== FAILURES ===================================
________________________________ test_geopandas ________________________________
[gw0] darwin -- Python 3.9.10 /usr/local/miniconda/envs/pandas-dev/bin/python

    @pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning")
    def test_geopandas():
    
        geopandas = import_module("geopandas")
        fp = geopandas.datasets.get_path("naturalearth_lowres")
>       assert geopandas.read_file(fp) is not None

pandas/tests/test_downstream.py:203: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/local/miniconda/envs/pandas-dev/lib/python3.9/site-packages/geopandas/io/file.py:166: in _read_file
    _check_fiona("'read_file' function")
E           ImportError: the 'read_file' function requires the 'fiona' package, but it is not installed or does not import correctly.
E           Importing fiona resulted in: dlopen(/usr/local/miniconda/envs/pandas-dev/lib/python3.9/site-packages/fiona/ogrext.cpython-39-darwin.so, 2): Library not loaded: @rpath/libfontconfig.1.dylib
E             Referenced from: /usr/local/miniconda/envs/pandas-dev/lib/libpoppler.117.0.0.dylib
E             Reason: Incompatible library version: libpoppler.117.dylib requires version 14.0.0 or later, but libfontconfig.1.dylib provides version 13.0.0

@mroeschke mroeschke added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Mar 9, 2022
@jbrockmendel
Copy link
Member

This test passes for me locally on MacOS with py3.9.10. Maybe it's just a py310 thing?

@jorisvandenbossche
Copy link
Member

This is a conda-forge packaging hickup, was going to open an issue but they are already aware / trying to fix it: conda-forge/fontconfig-feedstock#54 / conda-forge/fontconfig-feedstock#53 (comment)

This test passes for me locally on MacOS with py3.9.10. Maybe it's just a py310 thing?

It shouldn't be related to the python version, I would think (since it's a C dependency), but note that it's only an issue with the latest version of the package from conda-forge on Mac (so would need to have created such an environment the last day to see the issue locally-

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't think we need to put too much effort in fine tuning the exact skip, since we will be able to remove it again in a few days if all the packages have been rebuilt.

@@ -196,6 +201,13 @@ def test_pandas_datareader():

# importing from pandas, Cython import warning
@pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning")
@pytest.mark.xfail(
is_platform_mac() and (PY39 or PY310),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a failure in python 3.8 test on MacOS as well.

@mroeschke
Copy link
Member Author

mroeschke commented Mar 9, 2022

Looks like on the latest main run this affects 3.9 and 3.10:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=75056&view=logs&jobId=b1891a80-bdb0-5193-5f59-ce68a0874df0&j=b1891a80-bdb0-5193-5f59-ce68a0874df0

EDIT: Okay I'll just skip generally for MacOS then knowing that we can remove it soon.

@mroeschke mroeschke merged commit 471319b into pandas-dev:main Mar 10, 2022
@mroeschke
Copy link
Member Author

Do you recommend a backport for this @jorisvandenbossche or should we not bother since it should be fixed in the next couple of days?

@mroeschke mroeschke deleted the ci/geopandas/install branch March 10, 2022 18:41
@mroeschke mroeschke added this to the 1.5 milestone Mar 10, 2022
@jorisvandenbossche
Copy link
Member

That probably depends on the timeline of 1.4.2. Although I would assume this should be fixed by now, we can check by removing the skip again.

@jorisvandenbossche
Copy link
Member

-> #46320

jreback pushed a commit that referenced this pull request Mar 11, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…ndas-dev#46296)

* CI: xfail geopandas downstream test on MacOS due to fiona install

* More specific case

* Just skip generally for mac
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants