-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: xfail geopandas downstream test on MacOS due to fiona install #46296
Conversation
This test passes for me locally on MacOS with py3.9.10. Maybe it's just a py310 thing? |
This is a conda-forge packaging hickup, was going to open an issue but they are already aware / trying to fix it: conda-forge/fontconfig-feedstock#54 / conda-forge/fontconfig-feedstock#53 (comment)
It shouldn't be related to the python version, I would think (since it's a C dependency), but note that it's only an issue with the latest version of the package from conda-forge on Mac (so would need to have created such an environment the last day to see the issue locally- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I don't think we need to put too much effort in fine tuning the exact skip, since we will be able to remove it again in a few days if all the packages have been rebuilt.
pandas/tests/test_downstream.py
Outdated
@@ -196,6 +201,13 @@ def test_pandas_datareader(): | |||
|
|||
# importing from pandas, Cython import warning | |||
@pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning") | |||
@pytest.mark.xfail( | |||
is_platform_mac() and (PY39 or PY310), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a failure in python 3.8 test on MacOS as well.
Looks like on the latest main run this affects 3.9 and 3.10: EDIT: Okay I'll just skip generally for MacOS then knowing that we can remove it soon. |
Do you recommend a backport for this @jorisvandenbossche or should we not bother since it should be fixed in the next couple of days? |
That probably depends on the timeline of 1.4.2. Although I would assume this should be fixed by now, we can check by removing the skip again. |
-> #46320 |
…ndas-dev#46296) * CI: xfail geopandas downstream test on MacOS due to fiona install * More specific case * Just skip generally for mac
…tall (pandas-dev#46296)" (pandas-dev#46320) This reverts commit 471319b.
Not really familiar with geopandas to know why this install fails on MacOS, so xfailing for now (maybe there's a more lightweight test that doesn't read a file?)
cc @jorisvandenbossche
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=75056&view=logs&jobId=b1891a80-bdb0-5193-5f59-ce68a0874df0&j=b1891a80-bdb0-5193-5f59-ce68a0874df0&t=0a58a9e9-0673-539c-5bde-d78a5a3b655e