EA interface: rename ExtensionArray._hasnans to ._hasna

[jorisvandenbossche]

As discussed in follow-up on #45024 (comment)

Since this is "public" for developers, we need to decide on a name now for 1.4. Using "na" instead of "nan" makes it consistent with the other missing values related methods in the EA interface (isna, dropna, fillna, _can_hold_na)

[jreback]

@jorisvandenbossche no more on 1.4

[jorisvandenbossche]

This is an innocent name change, but important to do now since it's public API. Given that the release is planned tomorrow or Sunday, I think that is certainly still enough time to merge something like this.

[jreback]

could add to the list here https://github.com/pandas-dev/pandas/pull/45519/files#diff-3f7d3759a83cc1c72e82eba2dca1ba180a8e9b7fd7eefde9e906ec349a214bdaL121

[jbrockmendel]

I chose _hasnans to be consistent with the Index.hasnans method, dont really give a darn.

[jreback]

I chose _hasnans to be consistent with the Index.hasnans method, dont really give a darn.

we could change that too

[simonjayhawkins]

I chose _hasnans to be consistent with the Index.hasnans method, dont really give a darn.

we could change that too

As that's public wouldn't that need a deprecation

[jreback]

I chose _hasnans to be consistent with the Index.hasnans method, dont really give a darn.

we could change that too

As that's public wouldn't that need a deprecation

no its experimental on an EA and private on Index

[jreback]

@meeseeksdev backport 1.4.x

[jreback]

@jorisvandenbossche if you can followup with a change in the docs (e.g. add _hasna) & also we need to followup on Index.

[jreback]

this needs a manual backport @jorisvandenbossche @simonjayhawkins

[simonjayhawkins]

I chose _hasnans to be consistent with the Index.hasnans method, dont really give a darn.

we could change that too

As that's public wouldn't that need a deprecation

no its experimental on an EA and private on Index

ok. should probably remove from the docs https://pandas.pydata.org/pandas-docs/dev/reference/api/pandas.Index.hasnans.html

[jbrockmendel]

the comment here should be updated, might no longer be relevant

[jorisvandenbossche]

no its experimental on an EA and private on Index

hasnans is a public property on both Index and Series, so as Simon says, that would need to be deprecated if we want to remove that. But that's a separate discussion.

[jorisvandenbossche]

@simonjayhawkins thanks for the backport!