REF: merge_asof dont use values_for_argsort #45475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appears you're trying to tackle joining on nullables from which #32306 would be relevant. |
|
I think this should go in, as even if we don't have a test case that fails on the existing version, the version here i think is reliable. Also this gets rid of the last clearly-antipattern usage of _values_for_argsort |
jbrockmendel
changed the title
mroeschke
reviewed
Jan 25, 2022
| @@ -1224,6 +1224,49 @@ def test_merge_on_nans(self, func, side): | |||
| else: | |||
| merge_asof(df, df_null, on="a") | |||
|
|
|||
| def test_by_nullable(self, any_numeric_ea_dtype): | |||
| # Note: this test passes if instead of using pd.array we use | |||
There was a problem hiding this comment.
Maybe note that the outcome of #32306 may be relevant to the expected behavior
mroeschke
approved these changes
Jan 25, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mroeschke @jreback
Original motivation here was to remove an anti-pattern usage of _values_for_argsort. In the process I found what I think should be a bug, but I haven't been able to write a test that exposes it, could use some help.