BUG: No error raised in to_stata() for -np.inf #45350 #45360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an absolute function when checking infinity, which includes both np.inf and -np.inf. Also changed the error message a bit. * Add similar tests but replacing np.inf with -np.inf and change the correct error message accordingly
mroeschke
reviewed
Jan 14, 2022
mroeschke
reviewed
Jan 14, 2022
mroeschke
reviewed
Jan 14, 2022
mroeschke
requested changes
Jan 14, 2022
* Change the fix to make it faster. * Group the two test for DataFrame containing np.inf or -np.inf into a separate test function. * Update doc/source/whatsnew/v1.5.0.rst
mroeschke
reviewed
Jan 14, 2022
mroeschke
reviewed
Jan 14, 2022
* Minor change in code style.
|
thanks @flcong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_stata()if the column contains-np.inf#45350