TST: xfail test_arrowparquet_options for windows #45354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/io/test_fsspec.py
Outdated
| @@ -161,6 +162,7 @@ def test_to_parquet_new_file(monkeypatch, cleared_fs): | |||
|
|
|||
|
|
|||
| @td.skip_if_no("pyarrow") | |||
| @pytest.mark.xfail(is_platform_windows(), reason="GH 45344") | |||
There was a problem hiding this comment.
is this failing all builds or should be strict=False?
There was a problem hiding this comment.
yah looks like it xpassed on one of the builds here
There was a problem hiding this comment.
Ah I added a terse check for only PY38 so I could avoid strict=False
mroeschke
added
the
Testing
|
See also the discussion in #45344, updating the pyarrow pin to 2 in pandas/ci/deps/azure-windows-38.yaml Line 26 in 5b2f4a5 is probably the "proper" fix that doesn't need an xfail. |
jorisvandenbossche
approved these changes
Jan 14, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 14, 2022
jreback
pushed a commit
that referenced
this pull request
Jan 14, 2022
…45365) Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xfailing for now to get the CI to green