Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: dont pass downcast=False to fillna from pytables #45010

Merged
merged 1 commit into from
Dec 22, 2021
Merged

REF: dont pass downcast=False to fillna from pytables #45010

merged 1 commit into from
Dec 22, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

That's the only place from which we pass downcast=False, so removing that makes it easier to deprecate downcast altogether #40988 (also just avoids using internals logic which is a goal anyway)

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Refactor Internal refactoring of code labels Dec 22, 2021
@jreback jreback added this to the 1.4 milestone Dec 22, 2021
@jreback jreback added the IO HDF5 read_hdf, HDFStore label Dec 22, 2021
@jreback jreback merged commit 3bb9e62 into pandas-dev:master Dec 22, 2021
@jbrockmendel jbrockmendel deleted the ref-pytables-block branch December 22, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions IO HDF5 read_hdf, HDFStore Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback