Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: remove MSVC workaround #45008

Merged
merged 1 commit into from
Jan 30, 2022
Merged

BLD: remove MSVC workaround #45008

merged 1 commit into from
Jan 30, 2022

Conversation

jbrockmendel
Copy link
Member

Shot in the dark to see if the upstream problem behind #23209 is resolved.

jreback
jreback requested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this bump up min versions of any windows things?

@jreback jreback added the Windows Windows OS label Dec 22, 2021
@jbrockmendel
Copy link
Member Author

does this bump up min versions of any windows things?

im not aware of anywhere that we specify those

@lithomas1
Copy link
Member

We're still on VS 2017 on the wheel repo. This needs to wait for MacPython/pandas-wheels#160.

@jbrockmendel
Copy link
Member Author

Thanks @lithomas1. Is there an ETA on that? i.e. should this be closed or just given the "Blocked" label?

@jbrockmendel jbrockmendel added Blocked Build Library building on various platforms labels Dec 22, 2021
@lithomas1
Copy link
Member

That patch is scheduled to land for the 1.4rc, but this'll probably have to land in 2.0 because we'll have to wait until after 1.4.0 is released to make sure that no issues are reported that will cause it to be rolled back(last time we upgraded to Visual Studio 2019, we had missing DLL issues).

@jbrockmendel jbrockmendel added this to the 2.0 milestone Dec 23, 2021
@jbrockmendel jbrockmendel marked this pull request as draft December 23, 2021 00:29
@simonjayhawkins simonjayhawkins modified the milestones: 2.0, 1.5 Jan 5, 2022
@simonjayhawkins
Copy link
Member

That patch is scheduled to land for the 1.4rc, but this'll probably have to land in 2.0 because we'll have to wait until after 1.4.0 is released to make sure that no issues are reported that will cause it to be rolled back(last time we upgraded to Visual Studio 2019, we had missing DLL issues).

changing milestone to 1.5

@lithomas1 lithomas1 marked this pull request as ready for review January 6, 2022 14:58
@lithomas1 lithomas1 marked this pull request as draft January 6, 2022 14:59
@lithomas1 lithomas1 marked this pull request as ready for review January 28, 2022 01:31
@jbrockmendel
Copy link
Member Author

@lithomas1 looks like MacPython/pandas-wheels#160 has been merged, does that mean we're good to go here?

@lithomas1
Copy link
Member

I think so.

@lithomas1 lithomas1 removed the Blocked label Jan 29, 2022
@jreback jreback merged commit f77480f into pandas-dev:main Jan 30, 2022
@jreback
Copy link
Contributor

jreback commented Jan 30, 2022

ok let's give this a go, thanks @lithomas1

might be worth updating install.rst with the min required MSVC version?

@jbrockmendel jbrockmendel deleted the windows-23209 branch January 30, 2022 18:53
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jbrockmendel @phofl
BLD: remove msvc workaround (pandas-dev#45008)
471e4b3
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
BLD: remove msvc workaround (pandas-dev#45008)
bc6ac25
tuxillo added a commit to DragonFlyBSD/DeltaPorts that referenced this pull request Jan 25, 2023
@tuxillo
math/py-pandas: Revert an upstream commit that broke the build.
9b8f48a 
 - Pandas not only removed upstream a fix for MSVC but also removed what
   allowed us to have working std::signbit, see:
     pandas-dev/pandas#45008
 - Revert that commit partially so that we fix the build error:
     pandas/_libs/window/aggregations.cpp:4951:18: error: 'signbit' was
     not declared in this scope
@tuxillo tuxillo mentioned this pull request Jan 25, 2023
Open
3 tasks
@newacct newacct mentioned this pull request Sep 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms Windows Windows OS
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

PERF: replace use of isnan once MSVC bug is fixed
4 participants
@jbrockmendel @lithomas1 @simonjayhawkins @jreback