[ArrayManager] TST: Convert skip into xfail and clean-up tests that now work #44571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
4 tasks
| request.node.add_marker(mark) | ||
|
|
||
|
|
||
| skip_array_manager_not_yet_implemented = pytest.mark.xfail( |
There was a problem hiding this comment.
excellent! ive got a half-implemented branch doing the same thing!
|
thanks @jorisvandenbossche |
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146
As discussed before, turning the generic "skip" into an "xfail", so it's easier to keep track of which tests start to pass (and also clean-up a whole bunch of tests that were indeed already passing).
For parametrized tests, sometimes it's only a subset of the tests that are failing/passing. So for those cases, added a helper function that adds the xfail mark inside the test based on a condition (instead of as decorator for the full test).