-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in __getitem__ raising for slice DatetimeIndex #43428
Conversation
� Conflicts: � doc/source/whatsnew/v1.3.3.rst
Best guess: if we have e.g. |
Hm good point, should we try to convert to slice and only if it fails, e.g. stays an ndarray, call take? |
i think thats what we're already doing isnt it? |
I've removed the cast. Added it and we only call take if we can not convert to slice |
…lice DatetimeIndex
…imeIndex (#43475) Co-authored-by: Patrick Hoefler <[email protected]>
@jbrockmendel Any idea why we used
maybe_indices_to_slice
instead of take like in loc?