Fixed regression for SettingWithCopyWarning showing incorrect stacklevel #42633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
jreback
reviewed
Jul 20, 2021
| df = DataFrame(np.arange(25).reshape(5, 5)) | ||
| chained = df.loc[:3] | ||
| with option_context("chained_assignment", "warn"): | ||
| with tm.assert_produces_warning(com.SettingWithCopyWarning) as t: |
There was a problem hiding this comment.
i think check_stacklevel is supposed to do this?
There was a problem hiding this comment.
Yeah thought so too, but test was passing with stacklevel 4 and 5
jreback
reviewed
Jul 20, 2021
| @@ -3745,7 +3745,7 @@ def _set_item_mgr(self, key, value: ArrayLike) -> None: | |||
| # try to set first as we want an invalid | |||
| # value exception to occur first | |||
| if len(self): | |||
| self._check_setitem_copy() | |||
| self._check_setitem_copy(stacklevel=5) | |||
There was a problem hiding this comment.
you can use the find_stack_level function i think its called
There was a problem hiding this comment.
yah at first i was trying to use find_stack_level sparingly, but might as well go for it
There was a problem hiding this comment.
Will do that as a follow up, since this would change the function signature I don't think we should backport this?
|
merging |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 22, 2021
…ning showing incorrect stacklevel
jreback
pushed a commit
that referenced
this pull request
Jul 23, 2021
…ng incorrect stacklevel (#42678) Co-authored-by: Patrick Hoefler <[email protected]>
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
…vel (pandas-dev#42633) Co-authored-by: Jeff Reback <[email protected]>
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…vel (pandas-dev#42633) Co-authored-by: Jeff Reback <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingWithCopyWarningon new pandas version #42570Is there a better way to check the stacklevel here?