Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.copy not consolidating #42579

Merged
merged 6 commits into from
Jul 23, 2021

Conversation

jbrockmendel
Copy link
Member

@mzeitlin11 did you want to suggest an improved warning message for .insert?

@mzeitlin11
Copy link
Member

@mzeitlin11 did you want to suggest an improved warning message for .insert?

Thanks for the heads up. Since this fix should be independent to that and don't want to hold up this pr, probably easiest as a separate pr

@simonjayhawkins
Copy link
Member

@jbrockmendel tests are failing. also needs release note for 1.3.1

@simonjayhawkins simonjayhawkins added Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version labels Jul 19, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3.1 milestone Jul 19, 2021
@simonjayhawkins
Copy link
Member

also needs release note for 1.3.1

bugfix section

@jreback
Copy link
Contributor

jreback commented Jul 20, 2021

hmm these failures unrelated? maybe merge master again

@jreback
Copy link
Contributor

jreback commented Jul 20, 2021

can you run some asv's as well to make sure this doesn't change perf drastically. maybe insert / concat / copy ones.

@jreback jreback merged commit 1b60699 into pandas-dev:master Jul 23, 2021
@jreback
Copy link
Contributor

jreback commented Jul 23, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 23, 2021

Something went wrong ... Please have a look at my logs.

@jbrockmendel jbrockmendel deleted the regr-42477 branch July 23, 2021 01:07
simonjayhawkins pushed a commit that referenced this pull request Jul 23, 2021
CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@lautcjc
Copy link

lautcjc commented Apr 1, 2022

I'm seeing this warning with Python 3.8.12; pandas 1.3.4 using this function to combine a list of data frames (from parquet files)
pd.concat(objs=[pd.read_parquet(path=i, use_nullable_dtypes=True) for i in local_files], axis=0, ignore_index=True).copy()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.3.0 PerformanceWarning: DataFrame is highly fragmented.
5 participants