ENH - Improved error message for interpolating IntegerArrays (#41565) #42503
Conversation
There was a problem hiding this comment.
Thanks for the pr @AartGoossens, sorry for the late review!
Is there a MaskedArray specific place we hit before ending up here? I think it would be better if we could catch it in a place where we know we have a MaskedArray (then we can compare the given methods to currently supported ones for masked data and just say that that interpolation method has not been implemented yet).
| raise ValueError( | ||
| f"Invalid fill method. Expecting {expecting}. Got {method}." | ||
| " Are you trying to interpolate an integer column?" | ||
| ) |
There was a problem hiding this comment.
This error seems like something which might occur more commonly in non-masked cases (from something like a typo) - maybe this is too specific (there are also other nullable types like Float which could end up here)
mzeitlin11
added
Error Reporting
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Thanks for the pr, going to close for now as stale, but please ping to reopen if you'd like to continue working on it! |
- [ ] tests added / passedThis PR improves the error message when trying to interpolate dtype integer with method="linear", as discussed in #41565.