Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Prefer conda-forge over defaults #42377

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 5, 2021

Apparently its recommended to install pyarrow from conda forge instead of the default conda channel(xref ContinuumIO/anaconda-issues#12314, https://arrow.apache.org/docs/python/install.html#using-conda), trying to see if this fixes it. I don't think this will mess up any other packages since conda-forge packages are published by package maintainers, so they shouldn't have build issues?

@lithomas1 lithomas1 marked this pull request as draft July 5, 2021 03:31
@lithomas1 lithomas1 marked this pull request as ready for review July 5, 2021 04:07
@lithomas1
Copy link
Member Author

lithomas1 commented Jul 5, 2021

Windows CI failure is a flaky ResourceWarning, feel free to restart the job(I cannot).

@lithomas1 lithomas1 added this to the 1.4 milestone Jul 5, 2021
@lithomas1 lithomas1 added the CI Continuous Integration label Jul 5, 2021
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes this should be fine.
The main reason that pyarrow mentions to install from conda-forge for the latest version is because of the default channel often being behind and not having the latest version built (that doesn't seem to be the case now, but so indeed not all features are included ..). I commented on the linked Anaconda issue about how this can be fixed on their side.

@simonjayhawkins
Copy link
Member

ci failure on numpydev also also seen on other PR #42367

=========================== short test summary info ============================
FAILED pandas/tests/scalar/timedelta/test_arithmetic.py::TestTimedeltaMultiplicationDivision::test_td_div_nan[nan1]
= 1 failed, 156395 passed, 15976 skipped, 857 xfailed, 6 xpassed in 1944.90s (0:32:24) =

@simonjayhawkins simonjayhawkins merged commit c373c4d into pandas-dev:master Jul 5, 2021
@simonjayhawkins
Copy link
Member

Thanks @lithomas1

@lithomas1 lithomas1 deleted the patch-1 branch July 5, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPS: pyarrow support for snappy not built on Windows Python 3.9
3 participants