Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #42323 on branch 1.3.x (BUG: Styler.to_latex now doesn't manipulate the Styler object.) #42327

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Backport PR #42323 on branch 1.3.x (BUG: Styler.to_latex now doesn't manipulate the Styler object.) #42327

merged 2 commits into from
Jun 30, 2021

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #42323: BUG: Styler.to_latex now doesn't manipulate the Styler object.

@lumberbot-app lumberbot-app bot added this to the 1.3 milestone Jun 30, 2021
@lumberbot-app lumberbot-app bot added Bug IO LaTeX to_latex Styler conditional formatting using DataFrame.style labels Jun 30, 2021
@simonjayhawkins
Copy link
Member

@attack68 this backport is failing. depends on another PR not backported?

@attack68
Copy link
Contributor

@attack68 this backport is failing. depends on another PR not backported?

just looked, and I strongly believe that since it uses obj = self._copy(deepcopy=True) it will depend on (#42187), which was a cleanup assigned to 1.4.0, although no reason it can't also be backported?

@jreback jreback merged commit 2c26ee7 into pandas-dev:1.3.x Jun 30, 2021
@jreback
Copy link
Contributor

jreback commented Jun 30, 2021

thanks @attack68

yep this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug IO LaTeX to_latex Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@meeseeksmachine @simonjayhawkins @attack68 @jreback