Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: simplify Styler clear mechanics and tests #42271

Merged
merged 13 commits into from
Jul 1, 2021

Conversation

attack68
Copy link
Contributor

The current mechanics are unstructured and the tests is not future proof (if new attributes are added tests will not pick these up and fail). This PR generalises the construction and future proofs the tests. No user facing change.

@attack68 attack68 added Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style Clean labels Jun 29, 2021
@jreback jreback added this to the 1.4 milestone Jul 1, 2021
@jreback jreback merged commit e64b7ee into pandas-dev:master Jul 1, 2021
@jreback
Copy link
Contributor

jreback commented Jul 1, 2021

sure

@attack68 attack68 deleted the styler_clear_clean branch July 3, 2021 07:25
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants