Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix to_datetime() cache behaviour to not omit duplicated output values #42261

Merged
merged 8 commits into from
Jul 4, 2021
Merged

BUG: Fix to_datetime() cache behaviour to not omit duplicated output values #42261

merged 8 commits into from
Jul 4, 2021

Conversation

zyc09
Copy link
Contributor

@zyc09 zyc09 commented Jun 26, 2021 •
edited
Loading

@jreback jreback added Bug Datetime Datetime data dtype labels Jul 1, 2021
@jreback jreback added this to the 1.4 milestone Jul 1, 2021
jreback
jreback requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note in 1.4. bug fix section for datetimelike

@zyc09
Copy link
Contributor Author

zyc09 commented Jul 2, 2021

Added a note

@zyc09 zyc09 requested a review from jreback July 3, 2021 13:48
@jreback jreback merged commit 50bca8e into pandas-dev:master Jul 4, 2021
@jreback
Copy link
Contributor

jreback commented Jul 4, 2021

thanks @zyc09

@lithomas1 lithomas1 mentioned this pull request Jul 22, 2021
Closed
3 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 22, 2021
Closed
3 tasks
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.3.x

@simonjayhawkins simonjayhawkins modified the milestones: 1.4, 1.3.1 Jul 22, 2021
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jul 22, 2021
@zyc09 @simonjayhawkins
Backport PR pandas-dev#42261 (BUG: Fix to_datetime() cache behaviour …
0257b9e 
…to not omit duplicated output values)
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 22, 2021
Merged
simonjayhawkins added a commit that referenced this pull request Jul 22, 2021
@simonjayhawkins @zyc09
Backport PR #42261 (BUG: Fix to_datetime() cache behaviour to not omi…
1781d5a 
…t duplicated output values) (#42660)

Co-authored-by: Zheyuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

BUG: With cache, to_datetime() returns pd.NaT for inputs that produce duplicated values
3 participants
@zyc09 @jreback @simonjayhawkins