REF: de-duplicate IntervalIndex._intersection #41929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failures looks spurious |
simonjayhawkins
added
Index
|
This might have caused a big slowdown, see https://pandas.pydata.org/speed/pandas/#index_object.IntervalIndexMethod.time_intersection_both_duplicate?python=3.8&Cython=0.29.21&p-param1=100000&commits=17391997-969688a9 (the range of commits also includes some other commits) |
4 tasks
The indexing bugfix might play a part, but it does seem likely that this is the culprit. Profiling it looks like drop_duplicates is the big time sink. |
|
ive got a IntervalArray.unique branch in the works that cuts this this from 4x down to 2x, still a ways to go. |
4 tasks
4 tasks
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made possible by #41863