TST: Old Issues #41674
Merged
TST: Old Issues #41674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
May 26, 2021
mroeschke
commented
- closes Selecting multi rows by string in a DatetimeIndexed DataFrame #16710
- closes BUG: to_latex with multicolumn and multiindex joins cells which are on different hierarchy levels #16719
- closes Bug: CustomBusinessHour bug with holidays #16867
- closes The groupby filter output differs if we run an aggregate function before #17091
- closes BUG: getitem access with floats and an object index #17286
- closes BUG: boolean frames multiplied by floats have dtypes=object #18549
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
mroeschke
added
the
Testing
|
|
||
| def test_bool_frame_mult_float(): | ||
| # GH 18549 | ||
| result = DataFrame(True, list("ab"), list("cd")) * 1.0 |
There was a problem hiding this comment.
nit, I think the result assignment should be just the op under test
Suggested change
| result = DataFrame(True, list("ab"), list("cd")) * 1.0 | |
| df = DataFrame(True, list("ab"), list("cd")) | |
| result = df * 1.0 |
|
thanks @mroeschke |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.