Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: share GroupBy.transform #41308

Merged
merged 2 commits into from
May 4, 2021
Merged

REF: share GroupBy.transform #41308

merged 2 commits into from
May 4, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added Groupby Refactor Internal refactoring of code labels May 4, 2021
@jreback jreback added this to the 1.3 milestone May 4, 2021
@jreback jreback requested a review from mroeschke May 4, 2021 20:58
@jreback
Copy link
Contributor

jreback commented May 4, 2021

looks fine @mroeschke quick glance if you would.

mroeschke
mroeschke approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The numba portion looks good.

@jreback jreback merged commit a997bab into pandas-dev:master May 4, 2021
@jbrockmendel jbrockmendel deleted the ref-gb-transform-share branch May 4, 2021 21:55
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: share GroupBy.transform (pandas-dev#41308)
0f8a242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @mroeschke