TST: refactored tests to use parametrize instead of "for" loop #41195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ShaharNaveh
commented
Apr 28, 2021
ShaharNaveh
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
jreback
requested changes
Apr 28, 2021
pandas/tests/generic/test_series.py
Outdated
| @@ -52,33 +52,42 @@ def test_nonzero_single_element(self): | |||
| s = Series([False]) | |||
| assert not s.bool() | |||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
can you just put the Series iniside the test functions. (for all of these cases)
There was a problem hiding this comment.
I'm not sure I understand, what does it means "inside" the test functions?
I would really appreciate if you can post of example code for what you ment:)
There was a problem hiding this comment.
the parameters should be like [np.nan, pd.NatT] then simply construct what you need in the function
added 2 commits
May 3, 2021 14:41
jreback
approved these changes
May 3, 2021
|
thanks @ShaharNaveh |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.