TST: Regression test for #33765 #41169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ShaharNaveh
commented
Apr 26, 2021
ShaharNaveh
commented
- closes BUG: RecursionError when aligning column MultiIndex #33765
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
ShaharNaveh
commented
Apr 26, 2021
| @@ -1782,3 +1783,22 @@ def test_inplace_arithmetic_series_update(): | |||
|
|
|||
| expected = DataFrame({"A": [2, 3, 4]}) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
|
|
|||
| def test_arithemetic_multiindex_align(): # Needs a better name | |||
There was a problem hiding this comment.
Really not sure on how to call this.
Also not sure about the placement of the test
jreback
added
MultiIndex
Numeric Operations
jreback
requested changes
Apr 28, 2021
| @@ -1782,3 +1783,22 @@ def test_inplace_arithmetic_series_update(): | |||
|
|
|||
| expected = DataFrame({"A": [2, 3, 4]}) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
|
|
|||
| def test_arithemetic_multiindex_align(): # Needs a better name | |||
|
lgtm if you can make a not-draft can merge. |
|
There is a test failure that seems unrelated. Is there a possibility that the changes here, causing that test to fail? |
jreback
approved these changes
Apr 29, 2021
no this occasionaly fails |
|
thanks @ShaharNaveh |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.