Bug in loc not ordering rhs correctly for mixed indexer #40764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Apr 2, 2021
phofl
commented
- closes BUG: setting values with array in mixed DataFrame disregards order of indexer #40480
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
phofl
added
Indexing
|
looks fine. is this a user facing change or only a patch on AM? also merge master |
|
This is a regression on master, so not user facing |
|
is the array manager failure related? |
|
Sorry, did not scroll down up enough the last time. This fixes part of the array manager bug, but not the overwriting, so adjusted the test accordingly |
|
great thanks @phofl |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
jbrockmendel
reviewed
Nov 1, 2021
| df = DataFrame(index=[1, 2, 3], columns=["A", "B"], dtype=float) | ||
| df["B"] = "string" | ||
| df.loc[slice(3, 0, -1), "A"] = np.array([1, 2, 3], dtype="int64") | ||
| expected = DataFrame({"A": [3, 2, 1], "B": "string"}, index=[1, 2, 3]) |
There was a problem hiding this comment.
@phofl AFAICT the setting on L619 should be done in-place, so expected["A"] should still be float dtype. is the changed dtype relevant here?
There was a problem hiding this comment.
ditto for test_loc_setitem_frame_with_reindex_mixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.