[ArrayManager] DataFrame constructor from ndarray #40441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Refactor
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
| @@ -304,10 +305,26 @@ def ndarray_to_mgr( | |||
| index, columns = _get_axes( | |||
| values.shape[0], values.shape[1], index=index, columns=columns | |||
| ) | |||
| values = values.T | |||
|
|
|||
| _check_values_indices_shape_match(values, index, columns) | |||
There was a problem hiding this comment.
By moving values = values.T below _check_values_indices_shape_match, that function doesn't need to take the transposed shapes into account (and can be used for both AM and BM).
| for i in range(values.shape[1]) | ||
| ] | ||
| else: | ||
| if is_datetime_or_timedelta_dtype(values.dtype): |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146
Currently, the
DataFrame(ndarray)construction for ArrayManager still went through BlockManager and thenmgr_to_mgrconversion, which is less efficient.This PR adds a check in
ndarray_to_mgrfor directly creating an ArrayManager.It's still WIP, because there are still some validation steps that are now done inside BlockManager/Block inits, that need to be factored out / shared / added to ArrayManager path.